Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added Errors() read from kafkaSensor's producer #2959

Conversation

MenD32
Copy link
Contributor

@MenD32 MenD32 commented Dec 29, 2023

Checklist:

Fix issue #2958, added procuder.Errors() read and log to stop kafka sensor's producer from deadlocking.

@MenD32 MenD32 requested a review from whynowy as a code owner December 29, 2023 19:12
@MenD32 MenD32 force-pushed the bugfix/kafka-producer-errors-channel-deadlock branch 3 times, most recently from 6b12b50 to 55b4a14 Compare December 29, 2023 20:41
@MenD32 MenD32 marked this pull request as draft December 29, 2023 20:50
@MenD32 MenD32 marked this pull request as draft December 29, 2023 20:50
@MenD32 MenD32 marked this pull request as draft December 29, 2023 20:50
@MenD32 MenD32 force-pushed the bugfix/kafka-producer-errors-channel-deadlock branch from 55b4a14 to e31c0d7 Compare December 29, 2023 21:05
@MenD32 MenD32 marked this pull request as ready for review December 29, 2023 21:05
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@whynowy whynowy merged commit bec39df into argoproj:master Jan 1, 2024
8 checks passed
MenD32 added a commit to MenD32/argo-events that referenced this pull request Jan 13, 2024
ryancurrah pushed a commit to ryancurrah/argo-events that referenced this pull request Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants